From: Akira Fujita <a-fujita@rs.jp.nec.com>
Subject: Re: [RFC][PATCH 2/3] ext4 online defrag (ver 0.7)
Date: Fri, 07 Mar 2008 08:46:02 +0900
Message-ID: <47D0823A.3020209@rs.jp.nec.com>
References: <200803060001.AA00324@TNESG9526.rs.jp.nec.com> <20080306052552.GL3616@webber.adilger.int> <47CF8D19.8080703@rs.jp.nec.com> <47D01D8C.1000806@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Andreas Dilger <adilger@sun.com>, tytso@mit.edu, cmm@us.ibm.com,
	linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org
To: Eric Sandeen <sandeen@redhat.com>
In-Reply-To: <47D01D8C.1000806@redhat.com>
Sender: linux-ext4-owner@vger.kernel.org

Hello Eric,

>>>> Change the name of functions (ext4_ext_xxx -> ext4_defrag_xxx)
>>>> and some cleanups.
>>>>
>>>> -int ext4_ext_walk_space(struct inode *inode, ext4_lblk_t block,
>>>> -			ext4_lblk_t num, ext_prepare_callback func,
>>>> -			void *cbdata)
>>>> -{
>>>>     
>>>>         
>>> We were just going to be using this function for the FIEMAP support.
>>> I think there are several other functions which are not specific
>>> to defrag, so they shouldn't be renamed to be defrag specific.
>>>   
>>>       
>> ext4_ext_walk_space is no longer used by ext4 online defrag.
>> So I just removed from defrag.c not renamed.
>>
>> Shouldn't I remove ext4_ext_walk_space from defrag
>> for support FIEMAP?
>> I think it should be moved to extents.c
>>     
>
> I agree.  I'm working on FIEMAP, and I'll put it back into extents.c
> along with the FIEMAP patch, if you don't need it for defrag.
>
>   
OK. Please put ext4_ext_walk_space in extents.c.
Thank you for coping. :-)

Cheers Akira