From: Christoph Hellwig Subject: Re: [PATCH 2/3] jbd2: replace potentially false assertion with if block Date: Sat, 8 Mar 2008 13:45:43 -0500 Message-ID: <20080308184543.GA4284@infradead.org> References: <5e28cd633c71f6354a203a43000cbe5fef045589.1204844851.git.duaneg@dghda.com> <48afbb3a44aa24dc1e31835c14e86c3c6c1c3b0a.1204844851.git.duaneg@dghda.com> <20080307212336.GE1881@webber.adilger.int> <20080308150229.GA22430@infradead.org> <20080308164258.GA30512@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Andreas Dilger , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, Theodore Tso , sct@redhat.com, akpm@linux-foundation.org To: Duane Griffin Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:38995 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754198AbYCHSpq (ORCPT ); Sat, 8 Mar 2008 13:45:46 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Sat, Mar 08, 2008 at 06:37:08PM +0000, Duane Griffin wrote: > Sorry if I'm missing something here, but I think the caches do need to > be checked. If jbd/ext3 are not modular then even if initialisation > fails the journal code may still be called later. I noticed this when > testing the failure modes after making my original fix. Doh, I think you're right. Just because jbd initialization fails ext3 could succeed later on. We probably want to make ext3 initialization fail early in that case through an exported flag. > I've modified my changes to match the way you suggested doing things > in your earlier reply (and thanks for the review, BTW). If you would > prefer I'll rework my changes as a separate patch on top. Just let me > know. I don't really care how it's delivered. Just consider my patches a scetch and do whatever you think is best with them.