From: Akira Fujita <a-fujita@rs.jp.nec.com>
Subject: Re: [RFC][PATCH 0/3] ext4 online defrag (ver 0.7)
Date: Mon, 10 Mar 2008 19:48:12 +0900
Message-ID: <47D511EC.6000908@rs.jp.nec.com>
References: <200803060001.AA00322@TNESG9526.rs.jp.nec.com> <1204934917.14884.70.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
	format=flowed
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: tytso@mit.edu, linux-ext4@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
To: cmm@us.ibm.com
In-Reply-To: <1204934917.14884.70.camel@localhost.localdomain>
Sender: linux-ext4-owner@vger.kernel.org

Hello Mingming,

Thank you for review.  :-)=20

>> Next step:
>> Remove the limit of target file size (now 128MB) in -f mode.
>> * Past mail concerning -f mode.
>> http://marc.info/?l=3Dlinux-ext4&m=3D118239067704899&w=3D4
>>
>>    =20
>
> The old version have many useful high level description, could you
> preserve that and add to the change logs in this updated series?
>  =20
All right.  I'll do so next time.


>> Dependency:
>> My patches depend on the multi-block allocation in ext4 patch queue.
>>
>>    =20
> mballoc patch already in maintain so this dependency could be removed=
=2E
>  =20
We have to set mballoc mount option for ext4 online defrag,
because it doesn't support single block allocation.
So I think ext4 online defrag depends on mballoc.


>> Summary of patches:
>> * These patches are applied on the top of
>>   ext4 git tree(linux-2.6.25-rc3-git4).=20
>>   http://repo.or.cz/r/ext4-patch-queue.git
>>   And attached files are the updated patches.
>>
>>    =20
>
> I assume the following three patches are diffs against current ext4
> patch queue
>  =20
Exactly.  Sorry for the confusion.


>> [PATCH 1/3]
>>  - Interchange the data blocks of the target and
>>    temporary files in an atomic manner.
>>
>> [PATCH 2/3]
>> =E3=80=80- Change the name of functions.
>> =E3=80=80   ext4_ext_xxx -> ext4_defrag_xxx
>> =E3=80=80- Some cleanups.
>>
>> [PATCH 3/3] ext4 online defrag command
>>  - Change the error handling for ext4_iget().
>>  - Usage is as follows:
>>    o Put the multiple files closer together.
>>      # e4defrag -r directory-name
>>    o Defrag for free space fragmentation.
>>      # e4defrag -f file-name
>>    o Defrag for a single file.
>>      # e4defrag file-name
>>    o Defrag for all files on ext4.
>>      # e4defrag device-name
>>
>> Review and comment are welcome.
>>
>>    =20
>
> Attempted to do so...
>
> The updated patch series could not compile one-by-one, could you rewo=
rk
> the series so that in the future we could able to bi-search the ext4
> patch queue?
OK.
I'll make my updated patches to compile one-by-one
then resend them to you.


> As a whole, I got compile warning when applied all the
> updated patches:(
>  =20
Oops, I'll fix it.  =3D-O=20

> review comments against the 4 updated kernel patches to follow.
>  =20
I am confirming your review comments.=20
It will take time a little. :-)=20

Regards, Akira


--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" i=
n
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html