From: Andreas Dilger Subject: Re: [PATCH, RFC] jbd2: Add commit time into the commit block Date: Sun, 16 Mar 2008 09:26:02 +0800 Message-ID: <20080316012602.GZ3542@webber.adilger.int> References: <1205629144-25994-1-git-send-email-tytso@mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7BIT Cc: linux-ext4@vger.kernel.org To: "Theodore Ts'o" Return-path: Received: from sca-es-mail-2.Sun.COM ([192.18.43.133]:37081 "EHLO sca-es-mail-2.sun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752010AbYCPB0f (ORCPT ); Sat, 15 Mar 2008 21:26:35 -0400 Received: from fe-sfbay-10.sun.com ([192.18.43.129]) by sca-es-mail-2.sun.com (8.13.7+Sun/8.12.9) with ESMTP id m2G1QYL1010680 for ; Sat, 15 Mar 2008 18:26:34 -0700 (PDT) Received: from conversion-daemon.fe-sfbay-10.sun.com by fe-sfbay-10.sun.com (Sun Java System Messaging Server 6.2-8.04 (built Feb 28 2007)) id <0JXS00E01UI22A00@fe-sfbay-10.sun.com> (original mail from adilger@sun.com) for linux-ext4@vger.kernel.org; Sat, 15 Mar 2008 18:26:34 -0700 (PDT) In-reply-to: <1205629144-25994-1-git-send-email-tytso@mit.edu> Content-disposition: inline Sender: linux-ext4-owner@vger.kernel.org List-ID: On Mar 15, 2008 20:59 -0400, Theodore Ts'o wrote: > Carlo Wood has demonstrated that it's possible to recover deleted > files from the journal. Something that will make this easier is if we > can put the time of the commit into commit block. Note that we'd still be a lot further ahead undelete- and performance-wise if we avoided overwriting the indirect blocks in the first place... As it is, this is only really useful if you pull the plug after the delete. No harm in doing it, but won't help you recover as much as you could. Cheers, Andreas -- Andreas Dilger Sr. Staff Engineer, Lustre Group Sun Microsystems of Canada, Inc.