From: Geert Uytterhoeven Subject: Re: ext4 compile error on m68k Date: Sat, 5 Apr 2008 13:48:02 +0200 (CEST) Message-ID: References: <20080405102408.GB30987@cs181133002.pp.htv.fi> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: "Aneesh Kumar K.V" , sct@redhat.com, akpm@linux-foundation.org, adilger@clusterfs.com, zippel@linux-m68k.org, linux-ext4@vger.kernel.org, linux-m68k@vger.kernel.org To: Adrian Bunk Return-path: Received: from yergi.telenet-ops.be ([195.130.132.36]:58681 "EHLO yergi.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751504AbYDELsn (ORCPT ); Sat, 5 Apr 2008 07:48:43 -0400 Received: from wilson.telenet-ops.be (unknown [195.130.132.42]) by yergi.telenet-ops.be (Postfix) with ESMTP id F2EAC5C9EC5 for ; Sat, 5 Apr 2008 13:48:48 +0200 (CEST) In-Reply-To: <20080405102408.GB30987@cs181133002.pp.htv.fi> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Sat, 5 Apr 2008, Adrian Bunk wrote: > Commit aa02ad67d9b308290fde390682cd039b29f7ab85 > "ext4: Add ext4_find_next_bit()" causes the following regression: > > <-- snip --> > > ... > CC [M] fs/ext4/mballoc.o > /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/ext4/mballoc.c: In function 'mb_find_next_bit': > /home/bunk/linux/kernel-2.6/git/linux-2.6/fs/ext4/mballoc.c:696: error: implicit declaration of function 'generic_find_next_le_bit' > make[3]: *** [fs/ext4/mballoc.o] Error 1 > > <-- snip --> Known issue. The ext4 developers added a #define (with a different name than in the patch comment) in the commit below, but forgot to make sure generic_find_next_le_bit() is actually available. commit aa02ad67d9b308290fde390682cd039b29f7ab85 Author: Aneesh Kumar K.V Date: Mon Jan 28 23:58:27 2008 -0500 ext4: Add ext4_find_next_bit() This function is used by the ext4 multi block allocator patches. Also add generic_find_next_le_bit Signed-off-by: Aneesh Kumar K.V Cc: Signed-off-by: Andrew Morton diff --git a/include/asm-m68k/bitops.h b/include/asm-m68k/bitops.h index 2976b5d..83d1f28 100644 --- a/include/asm-m68k/bitops.h +++ b/include/asm-m68k/bitops.h @@ -410,6 +410,8 @@ static inline int ext2_find_next_zero_bit(const void *vaddr res = ext2_find_first_zero_bit (p, size - 32 * (p - addr)); return (p - addr) * 32 + res; } +#define ext2_find_next_bit(addr, size, off) \ + generic_find_next_le_bit((unsigned long *)(addr), (size), (off)) #endif /* __KERNEL__ */ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds