From: Andi Kleen Subject: Re: [PATCH 1/1] x86: fix text_poke Date: Fri, 25 Apr 2008 17:48:54 +0200 Message-ID: <20080425154854.GC3265@one.firstfloor.org> References: <20080425.021301.193689806.davem@davemloft.net> <1209343883-7991-1-git-send-email-jirislaby@gmail.com> <20080425151931.GA25510@elte.hu> <20080425152650.GA894@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ingo Molnar , Jiri Slaby , David Miller , zdenek.kabelac@gmail.com, rjw@sisk.pl, paulmck@linux.vnet.ibm.com, akpm@linux-foundation.org, linux-ext4@vger.kernel.org, herbert@gondor.apana.org.au, penberg@cs.helsinki.fi, clameter@sgi.com, linux-kernel@vger.kernel.org, Mathieu Desnoyers , Andi Kleen , pageexec@freemail.hu, "H. Peter Anvin" , Jeremy Fitzhardinge To: Linus Torvalds Return-path: Received: from one.firstfloor.org ([213.235.205.2]:42029 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751967AbYDYPnB (ORCPT ); Fri, 25 Apr 2008 11:43:01 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: > - if it's naturally aligned, it couldn't be page crossing ANYWAY > - and if it was a page-crosser, it sure as hell couldn't be atomic! With the current code it doesn't need to be atomic anyways because all patching is done with other CPUs stopped, except for kprobes but those only ever write a single byte. So all these checks can be just removed. -Andi