From: Linus Torvalds Subject: Re: [PATCH 1/1] x86: fix text_poke Date: Fri, 25 Apr 2008 09:51:30 -0700 (PDT) Message-ID: References: <20080425.021301.193689806.davem@davemloft.net> <1209343883-7991-1-git-send-email-jirislaby@gmail.com> <20080425151931.GA25510@elte.hu> <20080425152650.GA894@elte.hu> <20080425154854.GC3265@one.firstfloor.org> <20080425162215.GA16273@elte.hu> <20080425164509.GB19962@elte.hu> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Andi Kleen , Jiri Slaby , David Miller , zdenek.kabelac@gmail.com, rjw@sisk.pl, paulmck@linux.vnet.ibm.com, akpm@linux-foundation.org, linux-ext4@vger.kernel.org, herbert@gondor.apana.org.au, penberg@cs.helsinki.fi, clameter@sgi.com, linux-kernel@vger.kernel.org, Mathieu Desnoyers , pageexec@freemail.hu, "H. Peter Anvin" , Jeremy Fitzhardinge To: Ingo Molnar Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:33793 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760265AbYDYQxi (ORCPT ); Fri, 25 Apr 2008 12:53:38 -0400 In-Reply-To: <20080425164509.GB19962@elte.hu> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Fri, 25 Apr 2008, Ingo Molnar wrote: > > ah, on 64-bit. That we better make consistent anyway, via the patch > below. set_pte_phys() needs to become non-init as well. Make it return the "pte_t *", and now you don't have to walk the page tables twice to just clear it immediately afterwards. At that point I think my patch will be happy and useful, but I also worry a bit whether it was worth the changes.. Linus