From: Linus Torvalds Subject: Re: [PATCH 1/1] x86: fix text_poke Date: Fri, 25 Apr 2008 10:13:29 -0700 (PDT) Message-ID: References: <20080425151931.GA25510@elte.hu> <20080425152650.GA894@elte.hu> <20080425154854.GC3265@one.firstfloor.org> <20080425162215.GA16273@elte.hu> <20080425164509.GB19962@elte.hu> <20080425170237.GA24472@elte.hu> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Andi Kleen , Jiri Slaby , David Miller , zdenek.kabelac@gmail.com, rjw@sisk.pl, paulmck@linux.vnet.ibm.com, akpm@linux-foundation.org, linux-ext4@vger.kernel.org, herbert@gondor.apana.org.au, penberg@cs.helsinki.fi, clameter@sgi.com, linux-kernel@vger.kernel.org, Mathieu Desnoyers , pageexec@freemail.hu, "H. Peter Anvin" , Jeremy Fitzhardinge To: Ingo Molnar Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:52049 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758823AbYDYRPj (ORCPT ); Fri, 25 Apr 2008 13:15:39 -0400 In-Reply-To: <20080425170237.GA24472@elte.hu> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Fri, 25 Apr 2008, Ingo Molnar wrote: > > performance i dont think we should be too worried about at this moment - > this code is so rarely used that it should be driven by robustness i > think. That really isn't true. This isn't done just once. It's done many thousands of times. I agree that it has to be robust, but if we want to make suspend/resume be instantaneous (and we do), performance does actually matter. Yes, this is probably much less of a problem than waiting for devices, and no, I haven't timed it, but if I counted right, we'll literally be going almost ten thousand of these calls over a suspend/resume cycle. That's not "rarely used". Linus