From: Andi Kleen Subject: Re: [PATCH 1/1] x86: fix text_poke Date: Fri, 25 Apr 2008 19:26:51 +0200 Message-ID: <20080425172651.GF3265@one.firstfloor.org> References: <20080425152650.GA894@elte.hu> <20080425154854.GC3265@one.firstfloor.org> <20080425162215.GA16273@elte.hu> <20080425164509.GB19962@elte.hu> <20080425170237.GA24472@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Ingo Molnar , Andi Kleen , Jiri Slaby , David Miller , zdenek.kabelac@gmail.com, rjw@sisk.pl, paulmck@linux.vnet.ibm.com, akpm@linux-foundation.org, linux-ext4@vger.kernel.org, herbert@gondor.apana.org.au, penberg@cs.helsinki.fi, clameter@sgi.com, linux-kernel@vger.kernel.org, Mathieu Desnoyers , pageexec@freemail.hu, "H. Peter Anvin" , Jeremy Fitzhardinge To: Linus Torvalds Return-path: Received: from one.firstfloor.org ([213.235.205.2]:45136 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752014AbYDYRU5 (ORCPT ); Fri, 25 Apr 2008 13:20:57 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: > I agree that it has to be robust, but if we want to make suspend/resume > be instantaneous (and we do), performance does actually matter. Yes, this For suspend/resume we can actually just disable all the text_poke()s. They are not needed because we don't expect to stay in single CPU mode for long after wake up and they will just be undone again. I guess if it really was a problem (but really I haven't heard about it) the easiest fix would be to just extended system_state to SYSTEM_SUSPEND and then skip them if that is true. -Andi