From: Linus Torvalds Subject: Re: [PATCH 1/1] x86: fix text_poke Date: Fri, 25 Apr 2008 13:51:24 -0700 (PDT) Message-ID: References: <20080425152650.GA894@elte.hu> <20080425154854.GC3265@one.firstfloor.org> <20080425161916.GD3265@one.firstfloor.org> <20080425163035.GE9503@Krystal> <481209F2.4050908@zytor.com> <20080425170929.GA16180@Krystal> <20080425183748.GB16180@Krystal> <48123C9B.9020306@zytor.com> <20080425203717.GB25950@Krystal> <481241DC.3070601@zytor.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Mathieu Desnoyers , Andi Kleen , Ingo Molnar , Jiri Slaby , David Miller , zdenek.kabelac@gmail.com, rjw@sisk.pl, paulmck@linux.vnet.ibm.com, akpm@linux-foundation.org, linux-ext4@vger.kernel.org, herbert@gondor.apana.org.au, penberg@cs.helsinki.fi, clameter@sgi.com, linux-kernel@vger.kernel.org, pageexec@freemail.hu, Jeremy Fitzhardinge To: "H. Peter Anvin" Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:47157 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756091AbYDYU7V (ORCPT ); Fri, 25 Apr 2008 16:59:21 -0400 In-Reply-To: <481241DC.3070601@zytor.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Fri, 25 Apr 2008, H. Peter Anvin wrote: > > Yes, that should work. It's still ugly, and I have to say I find the > complexity rather distasteful. I am willing to be convinced it's worth it, > but I would really like to see hard numbers. I really cannot imagine that this kind of pain is *ever* worth it. Please give an example of something so important that we'd want to do complex code rewriting on the fly. What _is_ the point of imv_cond()? Linus