From: Jeremy Fitzhardinge Subject: Re: [PATCH 1/1] x86: fix text_poke Date: Mon, 28 Apr 2008 13:55:46 -0700 Message-ID: <481639D2.7040306@goop.org> References: <48123C9B.9020306@zytor.com> <20080425203717.GB25950@Krystal> <481241DC.3070601@zytor.com> <20080425211205.GC25950@Krystal> <481249FB.8070204@zytor.com> <20080425214704.GD25950@Krystal> <48125635.3060303@zytor.com> <20080425223015.GB31226@Krystal> <20080428202130.GF15840@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Linus Torvalds , Mathieu Desnoyers , "H. Peter Anvin" , Andi Kleen , Jiri Slaby , David Miller , zdenek.kabelac@gmail.com, rjw@sisk.pl, paulmck@linux.vnet.ibm.com, akpm@linux-foundation.org, linux-ext4@vger.kernel.org, herbert@gondor.apana.org.au, penberg@cs.helsinki.fi, clameter@sgi.com, linux-kernel@vger.kernel.org, pageexec@freemail.hu To: Ingo Molnar Return-path: Received: from gw.goop.org ([64.81.55.164]:60306 "EHLO mail.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935588AbYD1U4E (ORCPT ); Mon, 28 Apr 2008 16:56:04 -0400 In-Reply-To: <20080428202130.GF15840@elte.hu> Sender: linux-ext4-owner@vger.kernel.org List-ID: Ingo Molnar wrote: > And once we accept the static > markers, we might as well make them as cheap as possible. Sure, so long as you take "as cheap as possible" to mean cheap in both implementation complexity as well as runtime cost. I don't have any specific objections to any of the stuff that Mathieu is working on, but it does worry me that each time a problem is addressed it ends up being an even more subtle piece of code. I just haven't seen enough concrete justification to make me feel comfortable with it all. It seems to me that a relatively simple implementation which allows the desired tracing/marking functionality is the first step. If that proves to cause a significant performance deficit then enabled then we can work out how to address it in due course. But doing it all at once before merging anything seems like overkill, particularly when we're talking about specifics of gcc's codegen patterns, disassembling code fragments, etc. J