From: "Mulyadi Santosa" Subject: Re: Using tgid instead of pid in ext3_find_near() Date: Tue, 29 Apr 2008 07:57:05 +0700 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: "Kernel Newbies" , linux-ext4@vger.kernel.org To: "Manish Katiyar" Return-path: Received: from py-out-1112.google.com ([64.233.166.177]:14630 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755085AbYD2A5G (ORCPT ); Mon, 28 Apr 2008 20:57:06 -0400 Received: by py-out-1112.google.com with SMTP id u52so8187735pyb.10 for ; Mon, 28 Apr 2008 17:57:06 -0700 (PDT) In-Reply-To: Content-Disposition: inline Sender: linux-ext4-owner@vger.kernel.org List-ID: Ehmmm.... On Tue, Apr 29, 2008 at 2:07 AM, Manish Katiyar wrote: > Hi, > > In the function ext*_find_near() we are using pid to have the locality > of the blocks for the files which have same functionality. Shouldn't > we be using "current->tgid" here instead ?? > > 410 static ext3_fsblk_t ext3_find_near(struct inode *inode, Indirect *ind) > 411 { > ......... > ........ > 433 colour = (current->pid % 16) * > 434 (EXT3_BLOCKS_PER_GROUP(inode->i_sb) / 16); > ........ Because each threads even on same thread group doesn't need to share open file descriptors? regards, Mulyadi.