From: Jiri Slaby Subject: Re: [RFC 1/1] mm: add virt to phys debug Date: Tue, 06 May 2008 23:54:38 +0200 Message-ID: <4820D39E.3090109@gmail.com> References: <1209669740-10493-1-git-send-email-jirislaby@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-mm@kvack.org, Ingo Molnar , "H. Peter Anvin" , Jeremy Fitzhardinge , pageexec@freemail.hu, Mathieu Desnoyers , herbert@gondor.apana.org.au, penberg@cs.helsinki.fi, akpm@linux-foundation.org, linux-ext4@vger.kernel.org, paulmck@linux.vnet.ibm.com, rjw@sisk.pl, zdenek.kabelac@gmail.com, David Miller , Linus Torvalds , linux-kernel@vger.kernel.org, Andi Kleen To: Christoph Lameter Return-path: Received: from fk-out-0910.google.com ([209.85.128.189]:36884 "EHLO fk-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbYEFVyz (ORCPT ); Tue, 6 May 2008 17:54:55 -0400 Received: by fk-out-0910.google.com with SMTP id 18so9918fkq.5 for ; Tue, 06 May 2008 14:54:53 -0700 (PDT) In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On 05/01/2008 10:18 PM, Christoph Lameter wrote: > On Thu, 1 May 2008, Jiri Slaby wrote: >> Add some (configurable) expensive sanity checking to catch wrong address >> translations on x86. >> >> - create linux/mmdebug.h file to be able include this file in >> asm headers to not get unsolvable loops in header files >> - __phys_addr on x86_32 became a function in ioremap.c since >> PAGE_OFFSET and is_vmalloc_addr is undefined if declared in >> page_32.h (again circular dependencies) >> - add __phys_addr_const for initializing doublefault_tss.__cr3 > > Hmmm.. We could use include/linux/bounds.h to make > VMALLOC_START/VMALLOC_END (or whatever you need for checking the memory > boundaries) a cpp constant which may allow the use in page_32.h without > circular dependencies. I like the idea, I'll get back with a patch in few days (sorry, too busy). Anyway bounds.h should be include/asm/ thing though.