From: "Jose R. Santos" <jrs@us.ibm.com>
Subject: Re: [RFC PATCH 7/9][e2fsprogs] Add new blk64_t handling inline
 functions
Date: Mon, 12 May 2008 12:25:21 -0500
Message-ID: <20080512122521.4f9b270e@gara>
References: <20080509163928.15484.22146.stgit@gara>
	<20080509164012.15484.60952.stgit@gara>
	<20080512144903.GE7029@mit.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: linux-ext4@vger.kernel.org
To: Theodore Tso <tytso@mit.edu>
In-Reply-To: <20080512144903.GE7029@mit.edu>
Sender: linux-ext4-owner@vger.kernel.org

On Mon, 12 May 2008 10:49:03 -0400
Theodore Tso <tytso@mit.edu> wrote:

> On Fri, May 09, 2008 at 11:40:12AM -0500, Jose R. Santos wrote:
> > From: Jose R. Santos <jrs@us.ibm.com>
> > 
> > Add new blk64_t handling inline functions
> > 
> > Introduce inline fuctions to handle blk64_t and low/high values in
> > super blocks and inodes.
> 
> If you do this patch first, then you can address some of the FIXME's
> earlier in the patch series...

Will do.
 
> And as I mentioned, we probably want to avoid making them INLINE
> functions.  It's always easier to inline a function later if we find
> that it shows up on profiles for performance reasons, but if we find
> out we need to make changes and it is inline already, it's much harder
> to deal with the backwards compatibility issues.

I agree that making the not inline is the right thing to do, but now
the question is where do we put these new functions.  Is it still
appropriate to place them in ext2fs.h or do you prefer a new location?

> 						- Ted

-JRS