From: Subject: patch ext3-4-fix-uninitialized-bs-in-ext3-4_xattr_set_handle.patch added to 2.6.25-stable tree Date: Thu, 15 May 2008 12:04:45 -0700 Message-ID: <20080515195017.8C4AD14540CB@imap.suse.de> References: <200805150245.m4F2jI8E020348@hera.kernel.org> Cc: , To: tiger.yang@oracle.com, adilger@sun.com, agruen@suse.de, akpm@linux-foundation.org, gregkh@suse.de, linux-ext4@vger.kernel.org, torvalds@linux-foundation.org Return-path: Received: from mail.suse.de ([195.135.220.2]:48501 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758148AbYEOTuU (ORCPT ); Thu, 15 May 2008 15:50:20 -0400 In-Reply-To: <200805150245.m4F2jI8E020348@hera.kernel.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: This is a note to let you know that we have just queued up the patch titled Subject: ext3/4: fix uninitialized bs in ext3/4_xattr_set_handle() to the 2.6.25-stable tree. Its filename is ext3-4-fix-uninitialized-bs-in-ext3-4_xattr_set_handle.patch A git repo of this tree can be found at http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary >From stable-bounces@linux.kernel.org Wed May 14 19:45:26 2008 From: Tiger Yang Date: Thu, 15 May 2008 02:45:18 GMT Subject: ext3/4: fix uninitialized bs in ext3/4_xattr_set_handle() To: jejb@kernel.org, stable@kernel.org Message-ID: <200805150245.m4F2jI8E020348@hera.kernel.org> From: Tiger Yang commit 7e01c8e5420b6c7f9d85d34c15d8c7a15c9fc720 upstream This fix the uninitialized bs when we try to replace a xattr entry in ibody with the new value which require more than free space. This situation only happens we format ext3/4 with inode size more than 128 and we have put xattr entries both in ibody and block. The consequences about this bug is we will lost the xattr block which pointed by i_file_acl with all xattr entires in it. We will alloc a new xattr block and put that large value entry in it. The old xattr block will become orphan block. Signed-off-by: Tiger Yang Cc: Cc: Andreas Gruenbacher Acked-by: Andreas Dilger Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- fs/ext3/xattr.c | 5 +++++ fs/ext4/xattr.c | 5 +++++ 2 files changed, 10 insertions(+) --- a/fs/ext3/xattr.c +++ b/fs/ext3/xattr.c @@ -1000,6 +1000,11 @@ ext3_xattr_set_handle(handle_t *handle, i.value = NULL; error = ext3_xattr_block_set(handle, inode, &i, &bs); } else if (error == -ENOSPC) { + if (EXT3_I(inode)->i_file_acl && !bs.s.base) { + error = ext3_xattr_block_find(inode, &i, &bs); + if (error) + goto cleanup; + } error = ext3_xattr_block_set(handle, inode, &i, &bs); if (error) goto cleanup; --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -1011,6 +1011,11 @@ ext4_xattr_set_handle(handle_t *handle, i.value = NULL; error = ext4_xattr_block_set(handle, inode, &i, &bs); } else if (error == -ENOSPC) { + if (EXT4_I(inode)->i_file_acl && !bs.s.base) { + error = ext4_xattr_block_find(inode, &i, &bs); + if (error) + goto cleanup; + } error = ext4_xattr_block_set(handle, inode, &i, &bs); if (error) goto cleanup; Patches currently in stable-queue which might be from tiger.yang@oracle.com are queue-2.6.25/ext3-4-fix-uninitialized-bs-in-ext3-4_xattr_set_handle.patch