From: Martin Michlmayr Subject: Re: ext4dev build failure on mips: "empty_zero_page" undefined Date: Wed, 28 May 2008 09:06:38 +0200 Message-ID: <20080528070637.GA10393@deprecation.cyrius.com> References: <20080512130604.GA15008@deprecation.cyrius.com> <90edad820805120654n50f7a00cm3c7b4a4f9346d5ea@mail.gmail.com> <20080512143426.GB7029@mit.edu> <90edad820805120746l61e67362vbd177d63e8b05dc8@mail.gmail.com> <20080513045028.GC22226@linux-mips.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Dmitri Vorobiev , Theodore Tso , linux-mips@linux-mips.org, linux-ext4@vger.kernel.org To: Ralf Baechle Return-path: Received: from sorrow.cyrius.com ([65.19.161.204]:4210 "EHLO sorrow.cyrius.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750867AbYE1HHz (ORCPT ); Wed, 28 May 2008 03:07:55 -0400 Content-Disposition: inline In-Reply-To: <20080513045028.GC22226@linux-mips.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: * Ralf Baechle [2008-05-13 05:50]: > I prefer to do it myself so I can apply it at the same time to the MIPS > -stable branches. > > I'm a little irriated that this thread seems to be only about > empty_zero_page but apparently not zero_page_mask? empty_zero_page is > actualy an array of pages on MIPS and ZERO_PAGE() will pick the right one > for a particular user space mapping based on the virtual address but > ZERO_PAGE() also references zero_page_mask. So I sense more brokenness > here. Just as a reminder, this issue is still there (at least with rc4). -- Martin Michlmayr http://www.cyrius.com/