From: "Manish Katiyar" Subject: [PATCH] ext3 : Remove redundant condition in ext3_free_blocks_sb() Date: Sun, 1 Jun 2008 00:26:41 +0530 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit To: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org Return-path: Received: from ti-out-0910.google.com ([209.85.142.188]:31313 "EHLO ti-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756754AbYEaS4m (ORCPT ); Sat, 31 May 2008 14:56:42 -0400 Received: by ti-out-0910.google.com with SMTP id b6so128656tic.23 for ; Sat, 31 May 2008 11:56:41 -0700 (PDT) Content-Disposition: inline Sender: linux-ext4-owner@vger.kernel.org List-ID: For two unsigned values the check "block+count < block" is always false. Thus the below patch removes that condition. ============================================================= Signed-off-by: Manish Katiyar --- a/fs/ext3/balloc.c 2008-05-11 23:54:40.000000000 +0530 +++ b/fs/ext3/balloc.c 2008-06-01 00:05:25.000000000 +0530 @@ -493,7 +493,6 @@ sbi = EXT3_SB(sb); es = sbi->s_es; if (block < le32_to_cpu(es->s_first_data_block) || - block + count < block || block + count > le32_to_cpu(es->s_blocks_count)) { ext3_error (sb, "ext3_free_blocks", "Freeing blocks not in datazone - " ============================================================= -- Thanks & Regards, ******************************************** Manish Katiyar ( http://mkatiyar.googlepages.com ) 3rd Floor, Fair Winds Block EGL Software Park Off Intermediate Ring Road Bangalore 560071, India ***********************************************