From: "Manish Katiyar" Subject: Re: [PATCH] ext4 : Remove redundant condition in ext4_free_blocks_sb() Date: Sun, 1 Jun 2008 12:00:02 +0530 Message-ID: References: <5d4p8du0xc.fsf@Hurtta06k.keh.iki.fi> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org To: "Kari Hurtta" Return-path: Received: from ti-out-0910.google.com ([209.85.142.188]:23682 "EHLO ti-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751456AbYFAGaE (ORCPT ); Sun, 1 Jun 2008 02:30:04 -0400 Received: by ti-out-0910.google.com with SMTP id b6so149208tic.23 for ; Sat, 31 May 2008 23:30:02 -0700 (PDT) In-Reply-To: <5d4p8du0xc.fsf@Hurtta06k.keh.iki.fi> Content-Disposition: inline Sender: linux-ext4-owner@vger.kernel.org List-ID: On Sun, Jun 1, 2008 at 11:55 AM, Kari Hurtta wrote: > "Manish Katiyar" writes in > gmane.linux.file-systems: > >> For two unsigned values the check "block+count < block" is always >> false. Thus the below patch removes that condition. >> >> ============================================================= >> >> Signed-off-by: Manish Katiyar >> >> --- a/fs/ext4/balloc.c 2008-05-18 18:07:45.000000000 +0530 >> +++ b/fs/ext4/balloc.c 2008-06-01 00:05:48.000000000 +0530 >> @@ -619,7 +619,6 @@ >> sbi = EXT4_SB(sb); >> es = sbi->s_es; >> if (block < le32_to_cpu(es->s_first_data_block) || >> - block + count < block || >> block + count > ext4_blocks_count(es)) { >> ext4_error (sb, "ext4_free_blocks", >> "Freeing blocks not in datazone - " >> >> >> ============================================================= > > Hmm. Consider situation where block + count > max unsigned value > mathematically > > in that case > block + count < block > expression may be true Yeah.... my bad..... Al Viro pointed it out. Sorry for that > > >> -- >> Thanks & Regards, >> ******************************************** >> Manish Katiyar ( http://mkatiyar.googlepages.com ) >> 3rd Floor, Fair Winds Block >> EGL Software Park >> Off Intermediate Ring Road >> Bangalore 560071, India >> *********************************************** >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > / Kari Hurtta > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- Thanks & Regards, ******************************************** Manish Katiyar ( http://mkatiyar.googlepages.com ) 3rd Floor, Fair Winds Block EGL Software Park Off Intermediate Ring Road Bangalore 560071, India ***********************************************