From: Hidehiro Kawai Subject: [PATCH 3/5] jbd: abort when failed to log metadata buffers Date: Mon, 02 Jun 2008 19:46:02 +0900 Message-ID: <4843CF6A.7090107@hitachi.com> References: <4843CE15.6080506@hitachi.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: adilger@clusterfs.com, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, jack@suse.cz, jbacik@redhat.com, cmm@us.ibm.com, tytso@mit.edu, sugita , Satoshi OSHIMA To: akpm@linux-foundation.org, sct@redhat.com Return-path: Received: from mail7.hitachi.co.jp ([133.145.228.42]:52506 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752138AbYFBKqJ (ORCPT ); Mon, 2 Jun 2008 06:46:09 -0400 In-Reply-To: <4843CE15.6080506@hitachi.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: Subject: [PATCH 3/5] jbd: abort when failed to log metadata buffers If we failed to write metadata buffers to the journal space and succeeded to write the commit record, stale data can be written back to the filesystem as metadata in the recovery phase. To avoid this, when we failed to write out metadata buffers, abort the journal before writing the commit record. Signed-off-by: Hidehiro Kawai --- fs/jbd/commit.c | 3 +++ 1 file changed, 3 insertions(+) Index: linux-2.6.26-rc4/fs/jbd/commit.c =================================================================== --- linux-2.6.26-rc4.orig/fs/jbd/commit.c +++ linux-2.6.26-rc4/fs/jbd/commit.c @@ -734,6 +734,9 @@ wait_for_iobuf: /* AKPM: bforget here */ } + if (err) + journal_abort(journal, err); + jbd_debug(3, "JBD: commit phase 6\n"); if (journal_write_commit_record(journal, commit_transaction))