From: Hidehiro Kawai Subject: Re: [PATCH 1/5] jbd: strictly check for write errors on data buffers Date: Wed, 04 Jun 2008 19:53:48 +0900 Message-ID: <4846743C.5060400@hitachi.com> References: <4843CE15.6080506@hitachi.com> <4843CEED.9080002@hitachi.com> <20080603153050.fb99ac8a.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: sct@redhat.com, adilger@clusterfs.com, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, jack@suse.cz, jbacik@redhat.com, cmm@us.ibm.com, tytso@mit.edu, yumiko.sugita.yf@hitachi.com, satoshi.oshima.fk@hitachi.com To: Andrew Morton Return-path: Received: from mail7.hitachi.co.jp ([133.145.228.42]:49219 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754033AbYFDKyA (ORCPT ); Wed, 4 Jun 2008 06:54:00 -0400 In-Reply-To: <20080603153050.fb99ac8a.akpm@linux-foundation.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: Hi, Andrew Morton wrote: > On Mon, 02 Jun 2008 19:43:57 +0900 > Hidehiro Kawai wrote: > >>In ordered mode, we should abort journaling when an I/O error has >>occurred on a file data buffer in the committing transaction. > > Why should we do that? Aborting the journal leads the filesystem to read-only state, and it can prevent inconsistent state in file data from diffusing furthermore. I think it makes sense for ordered mode users; they don't want to lose file updates as much as possible, but they don't want to do fsync. Thanks, -- Hidehiro Kawai Hitachi, Systems Development Laboratory Linux Technology Center