From: Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Make some ext3 kernel messages useful by showing device
Date: Mon, 9 Jun 2008 13:49:18 -0700
Message-ID: <20080609134918.ed83d0d7.akpm@linux-foundation.org>
References: <1212951761.32756.4.camel@localhost>
	<20080609025926.0ecb6aea.akpm@linux-foundation.org>
	<484D3378.9090708@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Cc: lkml@metanurb.dk, linux-kernel@vger.kernel.org,
	linux-ext4@vger.kernel.org
To: Eric Sandeen <sandeen@redhat.com>
In-Reply-To: <484D3378.9090708@redhat.com>
Sender: linux-ext4-owner@vger.kernel.org

On Mon, 09 Jun 2008 08:43:20 -0500
Eric Sandeen <sandeen@redhat.com> wrote:

> > 
> > It is very much preferred, thanks.
> > 
> > (patch retained for linux-ext4 review)
> 
> The patch itself looks fine to me, and is a good idea.  I recently saw a
> confused user on another fs where successful mount messages were
> followed by failure mount messages with no indication of which fs had
> the trouble...
> 
> There probably are more spots in extX which could use this treatment...
> should we maybe just be using ext3_warning in more places, which
> automatically prints the sb, function name, etc?

Good point, thanks.