From: akpm@linux-foundation.org Subject: - ext3-abort-ext3-if-the-journal-has-aborted.patch removed from -mm tree Date: Mon, 09 Jun 2008 15:12:16 -0700 Message-ID: <200806092212.m59MCGvR010904@imap1.linux-foundation.org> To: hidehiro.kawai.ez@hitachi.com, jack@suse.cz, linux-ext4@vger.kernel.org, mm-commits@vger.kernel.org Return-path: Received: from smtp1.linux-foundation.org ([140.211.169.13]:36773 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758152AbYFIWMY (ORCPT ); Mon, 9 Jun 2008 18:12:24 -0400 Sender: linux-ext4-owner@vger.kernel.org List-ID: The patch titled ext3: abort ext3 if the journal has aborted has been removed from the -mm tree. Its filename was ext3-abort-ext3-if-the-journal-has-aborted.patch This patch was dropped because I don't think we want to go read-only on file data write errors The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/ ------------------------------------------------------ Subject: ext3: abort ext3 if the journal has aborted From: Hidehiro Kawai If the journal has aborted due to a checkpointing failure, we have to keep the contents of the journal space. ext3_put_super() detects the journal abort, then it invokes ext3_abort() to make the filesystem read only and keep needs_recovery flag. Signed-off-by: Hidehiro Kawai Acked-by: Jan Kara Cc: Signed-off-by: Andrew Morton --- fs/ext3/ioctl.c | 12 ++++++------ fs/ext3/super.c | 11 +++++++++-- 2 files changed, 15 insertions(+), 8 deletions(-) diff -puN fs/ext3/ioctl.c~ext3-abort-ext3-if-the-journal-has-aborted fs/ext3/ioctl.c --- a/fs/ext3/ioctl.c~ext3-abort-ext3-if-the-journal-has-aborted +++ a/fs/ext3/ioctl.c @@ -239,7 +239,7 @@ setrsvsz_out: case EXT3_IOC_GROUP_EXTEND: { ext3_fsblk_t n_blocks_count; struct super_block *sb = inode->i_sb; - int err; + int err, err2; if (!capable(CAP_SYS_RESOURCE)) return -EPERM; @@ -254,16 +254,16 @@ setrsvsz_out: } err = ext3_group_extend(sb, EXT3_SB(sb)->s_es, n_blocks_count); journal_lock_updates(EXT3_SB(sb)->s_journal); - journal_flush(EXT3_SB(sb)->s_journal); + err2 = journal_flush(EXT3_SB(sb)->s_journal); journal_unlock_updates(EXT3_SB(sb)->s_journal); group_extend_out: mnt_drop_write(filp->f_path.mnt); - return err; + return (err) ? err : err2; } case EXT3_IOC_GROUP_ADD: { struct ext3_new_group_data input; struct super_block *sb = inode->i_sb; - int err; + int err, err2; if (!capable(CAP_SYS_RESOURCE)) return -EPERM; @@ -280,11 +280,11 @@ group_extend_out: err = ext3_group_add(sb, &input); journal_lock_updates(EXT3_SB(sb)->s_journal); - journal_flush(EXT3_SB(sb)->s_journal); + err2 = journal_flush(EXT3_SB(sb)->s_journal); journal_unlock_updates(EXT3_SB(sb)->s_journal); group_add_out: mnt_drop_write(filp->f_path.mnt); - return err; + return (err) ? err : err2; } diff -puN fs/ext3/super.c~ext3-abort-ext3-if-the-journal-has-aborted fs/ext3/super.c --- a/fs/ext3/super.c~ext3-abort-ext3-if-the-journal-has-aborted +++ a/fs/ext3/super.c @@ -393,7 +393,8 @@ static void ext3_put_super (struct super int i; ext3_xattr_put_super(sb); - journal_destroy(sbi->s_journal); + if (journal_destroy(sbi->s_journal) < 0) + ext3_abort(sb, __func__, "Couldn't clean up the journal"); if (!(sb->s_flags & MS_RDONLY)) { EXT3_CLEAR_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER); es->s_state = cpu_to_le16(sbi->s_mount_state); @@ -2388,7 +2389,13 @@ static void ext3_write_super_lockfs(stru /* Now we set up the journal barrier. */ journal_lock_updates(journal); - journal_flush(journal); + + /* + * We don't want to clear needs_recovery flag when we failed + * to flush the journal. + */ + if (journal_flush(journal) < 0) + return; /* Journal blocked and flushed, clear needs_recovery flag. */ EXT3_CLEAR_INCOMPAT_FEATURE(sb, EXT3_FEATURE_INCOMPAT_RECOVER); _ Patches currently in -mm which might be from hidehiro.kawai.ez@hitachi.com are ext3-abort-ext3-if-the-journal-has-aborted.patch ext3-abort-ext3-if-the-journal-has-aborted-warning-fix.patch