From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [PATCH] ext4: Fix the loop condition in
	ext4_mb_free_committed_blocks
Date: Wed, 11 Jun 2008 17:04:35 +0530
Message-ID: <20080611113435.GD9008@skywalker>
References: <484F4CC1.3000109@cn.fujitsu.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: linux-ext4@vger.kernel.org, Theodore Tso <tytso@MIT.EDU>,
	Mingming Cao <cmm@us.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>
To: Shen Feng <shen@cn.fujitsu.com>
Content-Disposition: inline
In-Reply-To: <484F4CC1.3000109@cn.fujitsu.com>
Sender: linux-ext4-owner@vger.kernel.org

On Wed, Jun 11, 2008 at 11:55:45AM +0800, Shen Feng wrote:
> 
> Since md is freed before the do-while checks it,
> it's better to change it to while(1).
> 
> Signed-off-by: Shen Feng <shen@cn.fujitsu.com>

Reviewed-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>

> ---
>  fs/ext4/mballoc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/ext4/mballoc.c b/fs/ext4/mballoc.c
> index 42553f6..063f820 100644
> --- a/fs/ext4/mballoc.c
> +++ b/fs/ext4/mballoc.c
> @@ -2572,7 +2572,7 @@ ext4_mb_free_committed_blocks(struct super_block *sb)
>  		kfree(md);
>  		ext4_mb_release_desc(&e4b);
> 
> -	} while (md);
> +	} while (1);
> 
>  	mb_debug("freed %u blocks in %u structures\n", count, count2);
>  }
> -- 
> 1.5.4.5
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html