From: Mingming Cao <cmm@us.ibm.com>
Subject: Re: [PATCH] ext4: return error when calling ext4_ext_split failed
Date: Thu, 12 Jun 2008 15:20:00 -0700
Message-ID: <1213309200.3698.15.camel@localhost.localdomain>
References: <484F696A.4070703@cn.fujitsu.com>
Reply-To: cmm@us.ibm.com
Mime-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Cc: linux-ext4@vger.kernel.org, Theodore Tso <tytso@MIT.EDU>,
	Andrew Morton <akpm@linux-foundation.org>
To: Shen Feng <shen@cn.fujitsu.com>
In-Reply-To: <484F696A.4070703@cn.fujitsu.com>
Sender: linux-ext4-owner@vger.kernel.org

I have added to ext4 patch queue

Mingming
On Wed, 2008-06-11 at 13:58 +0800, Shen Feng wrote:
> ext4_ext_create_new_leaf must return error when its
> calling to ext4_ext_split failed.
> 
> Signed-off-by: Shen Feng <shen@cn.fujitsu.com>
> ---
>  fs/ext4/extents.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
> index ff609df..177345d 100644
> --- a/fs/ext4/extents.c
> +++ b/fs/ext4/extents.c
> @@ -981,6 +981,8 @@ repeat:
>  		/* if we found index with free entry, then use that
>  		 * entry: create all needed subtree and add new leaf */
>  		err = ext4_ext_split(handle, inode, path, newext, i);
> +		if (err)
> +			goto out;
> 
>  		/* refill path */
>  		ext4_ext_drop_refs(path);