From: Arjan van de Ven Subject: Re: [PATCH 3/3] Add timeout feature Date: Tue, 8 Jul 2008 23:41:20 -0700 Message-ID: <20080708234120.5072111f@infradead.org> References: <20080630212450t-sato@mail.jp.nec.com> <20080701081026.GB16691@infradead.org> <20080707110730.GG5643@ucw.cz> <20080708231026.GP11558@disturbed> <20080708232031.GE18195@elf.ucw.cz> <20080709005254.GQ11558@disturbed> <20080709010922.GE9957@mit.edu> <20080709061621.GA5260@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: hch@infradead.org, miklos@szeredi.hu, tytso@mit.edu, pavel@suse.cz, t-sato@yk.jp.nec.com, akpm@linux-foundation.org, viro@ZenIV.linux.org.uk, linux-ext4@vger.kernel.org, xfs@oss.sgi.com, dm-devel@redhat.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, axboe@kernel.dk, mtk.manpages@googlemail.com To: Miklos Szeredi Return-path: Received: from casper.infradead.org ([85.118.1.10]:40127 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751365AbYGIGmQ (ORCPT ); Wed, 9 Jul 2008 02:42:16 -0400 In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Wed, 09 Jul 2008 08:22:56 +0200 Miklos Szeredi wrote: > On Wed, 9 Jul 2008, Christoph Hellwig wrote: > > On Wed, Jul 09, 2008 at 08:13:21AM +0200, Miklos Szeredi wrote: > > > This would mean that freeze and thaw will have to be done on the > > > same file descriptor, but this isn't unreasonable to expect, is > > > it? > > > > It is certainly not the current use case, where you run one command > > to freeze the filesystem and another one to unfreeze it. > > So instead of > > freeze_fs mountpoint > backup-command > unfreeze_fs mountpoint > > the user would have do to > > run_freezed mountpoint backup-command > > I find the second one nicer, regardless of any reliability issues. nah he needs to do make_snapshot ; backup-command ; unref_snapshot. freezing isn't the right solution for the backup problem ;) -- If you want to reach me at my work email, use arjan@linux.intel.com For development, discussion and tips for power savings, visit http://www.lesswatts.org