From: "Duane Griffin" Subject: Re: latest -git: A peculiar case of a stuck process (ext3/sched-related?) Date: Fri, 18 Jul 2008 20:59:42 +0100 Message-ID: References: <19f34abd0807180245l2a633644n1a8d91cb3587d9e4@mail.gmail.com> <19f34abd0807180317g40a218a2p2bb2857c6f5aa659@mail.gmail.com> <19f34abd0807181005m19f1770bka9d8bbac7a500d1@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-ext4@vger.kernel.org, sct@redhat.com, akpm@linux-foundation.org, adilger@sun.com, "Ingo Molnar" , "Peter Zijlstra" , "Linux Kernel Mailing List" To: "Vegard Nossum" Return-path: Received: from ug-out-1314.google.com ([66.249.92.174]:56178 "EHLO ug-out-1314.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756085AbYGRT7o (ORCPT ); Fri, 18 Jul 2008 15:59:44 -0400 Received: by ug-out-1314.google.com with SMTP id h2so101420ugf.16 for ; Fri, 18 Jul 2008 12:59:42 -0700 (PDT) In-Reply-To: <19f34abd0807181005m19f1770bka9d8bbac7a500d1@mail.gmail.com> Content-Disposition: inline Sender: linux-ext4-owner@vger.kernel.org List-ID: 2008/7/18 Vegard Nossum : > (This patch looks much shorter than the one I found for ext2, though, > i.e. commit aa4f3f285643956bb614cf7b8f88e15f3a375886 from the > historical git repository. Does it fix all the right cases? I don't > mean to troll -- I just wanted to be sure you knew about it.) Ah, the historical git archive, that explains why I couldn't find it! Please, don't worry about being seen as trolling, I didn't know about that commit and I appreciate the heads-up and your attention to this in general. I've just taken a look at it and where I could find the corresponding ext3 code it all looked OK. The only change the commit makes that I couldn't verify was to ext2_add_link, as I couldn't immediately spot where the corresponding ext3 functionality is. Having said that, as I mentioned in the comment to that patch, there may well be similar problems still lurking. I tried to fix up all the dodgy looking cases at first, but I screwed up and just introduced more problems. After that it seemed safer to do a minimal fix and to address other similar issues as and when we got test-cases for them. With the sterling efforts of yourself and Sami we'll hopefully get them sooner or later. > I'll try it and report back if there's any trouble. Thanks, Thanks! > Vegard Cheers, Duane. -- "I never could learn to drink that blood and call it wine" - Bob Dylan