From: Mingming Cao Subject: Re: [PATCH -v2] ext4: Handle unwritten extent properly with delayed allocation. Date: Mon, 11 Aug 2008 14:49:49 -0700 Message-ID: <1218491389.6766.20.camel@mingming-laptop> References: <1218450188-9643-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: tytso@mit.edu, sandeen@redhat.com, linux-ext4@vger.kernel.org To: "Aneesh Kumar K.V" Return-path: Received: from e35.co.us.ibm.com ([32.97.110.153]:33454 "EHLO e35.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750852AbYHKVtw (ORCPT ); Mon, 11 Aug 2008 17:49:52 -0400 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e35.co.us.ibm.com (8.13.8/8.13.8) with ESMTP id m7BLnpox006461 for ; Mon, 11 Aug 2008 17:49:51 -0400 Received: from d03av02.boulder.ibm.com (d03av02.boulder.ibm.com [9.17.195.168]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.0) with ESMTP id m7BLnpFM152042 for ; Mon, 11 Aug 2008 15:49:51 -0600 Received: from d03av02.boulder.ibm.com (loopback [127.0.0.1]) by d03av02.boulder.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id m7BLnocB005543 for ; Mon, 11 Aug 2008 15:49:51 -0600 In-Reply-To: <1218450188-9643-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: > When using fallocate the buffer_heads are marked unwritten > and unmapped. We need to map them in the writepages after > a get_block. Otherwise we split the uninit extents, > but never write the content to disk. > > Signed-off-by: Aneesh Kumar K.V Reviewed-by: Mingming Cao Added to patch queue > --- > fs/ext4/inode.c | 12 ++++++++++-- > 1 files changed, 10 insertions(+), 2 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c > index c96cc0b..7a66bba 100644 > --- a/fs/ext4/inode.c > +++ b/fs/ext4/inode.c > @@ -1732,6 +1732,13 @@ static void mpage_put_bnr_to_bhs(struct mpage_da_data *mpd, sector_t logical, > if (buffer_delay(bh)) { > bh->b_blocknr = pblock; > clear_buffer_delay(bh); > + bh->b_bdev = inode->i_sb->s_bdev; > + } else if (buffer_unwritten(bh)) { > + bh->b_blocknr = pblock; > + clear_buffer_unwritten(bh); > + set_buffer_mapped(bh); > + set_buffer_new(bh); > + bh->b_bdev = inode->i_sb->s_bdev; > } else if (buffer_mapped(bh)) > BUG_ON(bh->b_blocknr != pblock); > > @@ -1805,7 +1812,7 @@ static void mpage_da_map_blocks(struct mpage_da_data *mpd) > * If blocks are delayed marked, we need to > * put actual blocknr and drop delayed bit > */ > - if (buffer_delay(lbh)) > + if (buffer_delay(lbh) || buffer_unwritten(lbh)) > mpage_put_bnr_to_bhs(mpd, next, &new); > > /* go for the remaining blocks */ > @@ -1814,7 +1821,8 @@ static void mpage_da_map_blocks(struct mpage_da_data *mpd) > } > } > > -#define BH_FLAGS ((1 << BH_Uptodate) | (1 << BH_Mapped) | (1 << BH_Delay)) > +#define BH_FLAGS ((1 << BH_Uptodate) | (1 << BH_Mapped) | \ > + (1 << BH_Delay) | (1 << BH_Unwritten)) > > /* > * mpage_add_bh_to_extent - try to add one more block to extent of blocks