From: Mark Fasheh Subject: Re: FIEMAP patches Date: Wed, 10 Sep 2008 05:40:05 -0700 Message-ID: <20080910124005.GA4563@wotan.suse.de> References: <20080825202250.GY3392@webber.adilger.int> Reply-To: Mark Fasheh Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Eric Sandeen , linux-ext4@vger.kernel.org, Kalpak Shah , Andrew Morton To: Andreas Dilger Return-path: Received: from ns1.suse.de ([195.135.220.2]:59632 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751856AbYIJMkI (ORCPT ); Wed, 10 Sep 2008 08:40:08 -0400 Content-Disposition: inline In-Reply-To: <20080825202250.GY3392@webber.adilger.int> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Mon, Aug 25, 2008 at 02:22:50PM -0600, Andreas Dilger wrote: > I read through the entire previous FIEMAP thread (phew!) and it boils > down mostly to: > > s/FIEMAP_FLAG_NO_DIRECT/FIEMAP_FLAG_NO_BYPASS/ > > > * FIEMAP_EXTENT_UNWRITTEN > > Unwritten extent - the extent is allocated but it's data has not been > > initialized. This indicates the extent's data will be all zero. > > This should say "will be all zero if read through the filesystem > but the contents are undefined if read directly from the device." > > There was also an update to the ext4 patch from Kalpak for handling > EA-in-inode at the same time as an external inode. Hmm, I didn't find this in my mailbox... The Ext4 patch I had doesn't apply any more either :( I think one of you all is going to have to send an update. > Eric, Mark, > could one of you please just submit the patches to Andrew for inclusion. > I think there was plenty of debate already, with very little significant > benefit except suggesting different names for some of the flags. Ok, sorry again for the delay. I am at a conference this week, then on vacation, then back to another conference, so I am having a rather busy month. None the less, I managed to bring the fiemap patches up to 2.6.27-rc6, with the changes discussed. They are in git: git://git.kernel.org/pub/scm/linux/kernel/git/mfasheh/ocfs2.git fiemap Individual patches will be mailed in response to this message. Andrew, are these patches ok for a spin in -mm? I agree with Andreas that this has been discussed to death, with very little benefit being extracted from the latest round. --Mark -- Mark Fasheh