From: Theodore Tso Subject: Re: [PATCH] ext3/jbd: Avoid WARN() messages when failing to write to the superblock Date: Sun, 21 Sep 2008 22:51:29 -0400 Message-ID: <20080922025129.GB9914@mit.edu> References: <1221946547-9873-1-git-send-email-tytso@mit.edu> <20080921173328.GB23547@atrey.karlin.mff.cuni.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: akpm@linux-foundation.org, Linux Kernel Developers List , Ext4 Developers List To: Jan Kara Return-path: Received: from www.church-of-our-saviour.org ([69.25.196.31]:48402 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751295AbYIVCve (ORCPT ); Sun, 21 Sep 2008 22:51:34 -0400 Content-Disposition: inline In-Reply-To: <20080921173328.GB23547@atrey.karlin.mff.cuni.cz> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Sun, Sep 21, 2008 at 07:33:28PM +0200, Jan Kara wrote: > > This fixes some very common warnings reported by kerneloops.org > > > > Signed-off-by: "Theodore Ts'o" > The patch looks nice but does it really fix the warnings? I see > at least ext3_put_super() calling mark_buffer_dirty() before calling > ext3_commit_super(). We should just remove that mark_buffer_dirty() > call. I tested it, and in practice it works, since mark_buffer_dirty() only causes a problem if an attempt to write to the superblock has already failed. I agree that we should just remove that mark_buffer_dirty() call, though, since ext3_put_super() calls ext3_commit_super() which calls mark_buffer_dirty() anyway. I'll respin the patch. > BTW: Do you plan doing a similar fix for ext2 and ext4? I have a similar fix for ext4 that is queued up to be pushed once the merge window opens. I haven't back-ported it to ext2 yet, but I will. - Ted