From: Chris Mason Subject: Re: [PATCH] Improve buffered streaming write ordering Date: Fri, 03 Oct 2008 15:45:55 -0400 Message-ID: <1223063155.13375.64.camel@think.oraclecorp.com> References: <1222886451.9158.34.camel@think.oraclecorp.com> <20081001215239.ee2ae63f.akpm@linux-foundation.org> <1222950054.6745.18.camel@think.oraclecorp.com> <20081002181856.GB29613@skywalker> <20081002234309.GH30001@disturbed> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "Aneesh Kumar K.V" , Andrew Morton , linux-kernel , linux-fsdevel , ext4 To: Dave Chinner Return-path: Received: from rgminet01.oracle.com ([148.87.113.118]:56926 "EHLO rgminet01.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752061AbYJCTwe (ORCPT ); Fri, 3 Oct 2008 15:52:34 -0400 In-Reply-To: <20081002234309.GH30001@disturbed> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Fri, 2008-10-03 at 09:43 +1000, Dave Chinner wrote: > On Thu, Oct 02, 2008 at 11:48:56PM +0530, Aneesh Kumar K.V wrote: > > On Thu, Oct 02, 2008 at 08:20:54AM -0400, Chris Mason wrote: > > > On Wed, 2008-10-01 at 21:52 -0700, Andrew Morton wrote: > > > For a 4.5GB streaming buffered write, this printk inside > > > ext4_da_writepage shows up 37,2429 times in /var/log/messages. > > > > > > > Part of that can happen due to shrink_page_list -> pageout -> writepagee > > call back with lots of unallocated buffer_heads(blocks). > > Quite frankly, a simple streaming buffered write should *never* > trigger writeback from the LRU in memory reclaim. The blktrace runs on ext4 didn't show kswapd doing any IO. It isn't clear if this is because ext4 did the redirty trick or if kswapd didn't call writepage. -chris