From: Ric Wheeler Subject: Re: [PATCH] improve jbd fsync batching Date: Tue, 28 Oct 2008 17:56:39 -0400 Message-ID: <49078A97.8020003@redhat.com> References: <20081028201614.GA21600@unused.rdu.redhat.com> <20081028213805.GC3184@webber.adilger.int> <20081028144401.07b7546d@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Andreas Dilger , Josef Bacik , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org To: Arjan van de Ven Return-path: In-Reply-To: <20081028144401.07b7546d@infradead.org> Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org Arjan van de Ven wrote: > On Tue, 28 Oct 2008 15:38:05 -0600 > Andreas Dilger wrote: > > >> On Oct 28, 2008 16:16 -0400, Josef Bacik wrote: >> >>> I also have a min() check in there to make sure we don't sleep >>> longer than a jiffie in case our storage is super slow, this was >>> requested by Andrew. >>> >> Is there a particular reason why 1 jiffie is considered the "right >> amount" of time to sleep, given this is a kernel config parameter and >> has nothing to do with the storage? Considering a seek time in the >> range of ~10ms this would only be right for HZ=100 and the wait would >> > > well... my disk does a 50 usec seek time or so.. so I don't mind ;-) > > in fact it sounds awefully long to me. > For small writes as well as reads? If so, it would be great to test Josef's patch against your shiny new SSD :-) ric