From: Andrew Morton Subject: Re: [PATCH] ext3: wait on all pending commits in ext3_sync_fs Date: Mon, 3 Nov 2008 13:27:35 -0800 Message-ID: <20081103132735.9e63a3d0.akpm@linux-foundation.org> References: <4908C951.2000309@redhat.com> <20081103184426.GA31894@ajones-laptop.nbttech.com> <20081103113318.35b0c266.akpm@linux-foundation.org> <20081103201428.GB30565@ajones-laptop.nbttech.com> <20081103123750.67c96224.akpm@linux-foundation.org> <20081103205854.GC30565@ajones-laptop.nbttech.com> <20081103131313.e9ae2f93.akpm@linux-foundation.org> <20081103211929.GA18117@mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: ajones@riverbed.com, sandeen@redhat.com, linux-ext4@vger.kernel.org, sct@redhat.com, linux-kernel@vger.kernel.org To: Theodore Tso Return-path: In-Reply-To: <20081103211929.GA18117@mit.edu> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-ext4.vger.kernel.org On Mon, 3 Nov 2008 16:19:29 -0500 Theodore Tso wrote: > On Mon, Nov 03, 2008 at 01:13:13PM -0800, Andrew Morton wrote: > > On Mon, 3 Nov 2008 12:58:54 -0800 > > Arthur Jones wrote: > > > > > Hi Andrew, ... > > > > > > On Mon, Nov 03, 2008 at 12:37:50PM -0800, Andrew Morton wrote: > > > > [...] > > > > OK. But still, questions remain. > > > > > > > > - should we clear s_dirt if log_wait_commit() didn't work? > > > > > > > > - ext3_force_commit() clears s_dirt also > > > > > > > > - should ext3_sync_fs() be dropping the ext3_force_commit() return > > > > value on the floor? > > Should all the callers of ->sync_fs also be dropping the error returns > on the floor? Oh, this is sync_fs. How meaningful would it be to return an error from sys_umount()? Would there be any point in leaving the errored fs mounted? Dunno. But if we're going to drop this error on the floor, we should do that at a higher level, not on a per-fs basis ;)