From: Christoph Hellwig Subject: Re: [PATCH]: ext4: fix big endian Date: Thu, 6 Nov 2008 12:39:44 -0500 Message-ID: <20081106173944.GA23398@infradead.org> References: <200811061600.54264.borntraeger@de.ibm.com> <200811061651.49602.borntraeger@de.ibm.com> <49131601.50407@redhat.com> <20081106163846.GA1381@infradead.org> <20081106173327.GF18939@mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: Theodore Tso , Christoph Hellwig , Peter Staubach , Christian Borntraeger , linux-ext4@vger.kernel.org, Return-path: Received: from bombadil.infradead.org ([18.85.46.34]:46659 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750806AbYKFRj4 (ORCPT ); Thu, 6 Nov 2008 12:39:56 -0500 Content-Disposition: inline In-Reply-To: <20081106173327.GF18939@mit.edu> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Thu, Nov 06, 2008 at 12:33:27PM -0500, Theodore Tso wrote: > On Thu, Nov 06, 2008 at 11:38:46AM -0500, Christoph Hellwig wrote: > > > > Yes. And if someone ran sparse over the code both the initial error > > and this varaint would be trivial to spot.. > > > > That's how Aneesh found it. :-) Heh, okay. We really should try to find some annotations that run sparse with endian checking by default for those parts of the tree where it makes sense..