From: Mark Fasheh Subject: Re: [PATCH -V1] ext4: Use new buffer_head flag to check uninit group bitmaps initialization Date: Wed, 26 Nov 2008 08:22:06 -0800 Message-ID: <20081126162206.GE8378@wotan.suse.de> References: <1227711250-13934-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <20081126155643.GA8741@mit.edu> Reply-To: Mark Fasheh Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Aneesh Kumar K.V" , cmm@us.ibm.com, sandeen@redhat.com, Alex.Zhuravlev@Sun.COM, linux-ext4@vger.kernel.org To: Theodore Tso Return-path: Received: from mx1.suse.de ([195.135.220.2]:39006 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752023AbYKZQWH (ORCPT ); Wed, 26 Nov 2008 11:22:07 -0500 Content-Disposition: inline In-Reply-To: <20081126155643.GA8741@mit.edu> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Wed, Nov 26, 2008 at 10:56:43AM -0500, Theodore Tso wrote: > On Wed, Nov 26, 2008 at 08:24:10PM +0530, Aneesh Kumar K.V wrote: > > diff --git a/include/linux/jbd2.h b/include/linux/jbd2.h > > index 4932b34..6694561 100644 > > --- a/include/linux/jbd2.h > > +++ b/include/linux/jbd2.h > > @@ -329,6 +329,7 @@ enum jbd_state_bits { > > BH_State, /* Pins most journal_head state */ > > BH_JournalHead, /* Pins bh->b_private and jh->b_bh */ > > BH_Unshadow, /* Dummy bit, for BJ_Shadow wakeup filtering */ > > + BH_JBD_State_bits_End, > > }; > > > > BUFFER_FNS(JBD, jbd) > > Note: this conflicts with a patch by Mark Fasheh which does something > very similar, since OCFS2 also needs some private BH flags. He used > the name BH_JBDPrivateStart, though. > > Originally the plan was going to be that Mark was going to send this > to Linus, but given that we need it as well, I suggest that we drop it > into both the OCFS2 and ext4 trees, and whichever one hits Linus's > tree first will win, and in the other case the magic of git's merge > algorithms should make the right thing happen in the second. (Or the > other team can drop the patch before they merge; either will do the > right thing.) Yeah, that's fine with me. We'll both carry it for now and the merge window will just get sorted out :) --Mark -- Mark Fasheh