From: "Duane Griffin" Subject: Re: [PATCH, v2] ext3: ensure link targets are NULL-terminated Date: Fri, 12 Dec 2008 09:40:43 +0000 Message-ID: References: <1229022995-9898-1-git-send-email-duaneg@dghda.com> <1229022995-9898-2-git-send-email-duaneg@dghda.com> <1229022995-9898-3-git-send-email-duaneg@dghda.com> <1229022995-9898-4-git-send-email-duaneg@dghda.com> <1229022995-9898-5-git-send-email-duaneg@dghda.com> <1229022995-9898-6-git-send-email-duaneg@dghda.com> <20081211222605.GB18665@dastardly.home.dghda.com> <20081211193228.51c34114.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Boaz Harrosh" , sct@redhat.com, adilger@sun.com, linux-ext4@vger.kernel.org To: "Andrew Morton" Return-path: Received: from nf-out-0910.google.com ([64.233.182.189]:16138 "EHLO nf-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751818AbYLLJkq (ORCPT ); Fri, 12 Dec 2008 04:40:46 -0500 In-Reply-To: <20081211193228.51c34114.akpm@linux-foundation.org> Content-Disposition: inline Sender: linux-ext4-owner@vger.kernel.org List-ID: 2008/12/12 Andrew Morton : > Really? The ext2 on-disk format requires that the fast symlink be > null-terminated on disk? Even though the length is already in i_size? > > It seems that's true. How un-ext2-like. > > ext2 and ext4 need the same fix, yes? Yes. I've sent them out already, but thanks to a monumental cock-up with the CCs they may not have made it to the list. I'll check and resend to real addresses if necessary. Cheers, Duane. -- "I never could learn to drink that blood and call it wine" - Bob Dylan