From: Theodore Tso Subject: Re: [PATCH] : Remove incompatible pointer assignment warning in ext4 quota operations Date: Thu, 12 Feb 2009 06:47:36 -0500 Message-ID: <20090212114736.GA13040@mini-me.lan> References: <20090202161005.GG19165@atrey.karlin.mff.cuni.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jan Kara , ext4 To: Manish Katiyar Return-path: Received: from THUNK.ORG ([69.25.196.29]:34791 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758383AbZBLQDp (ORCPT ); Thu, 12 Feb 2009 11:03:45 -0500 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Thu, Feb 12, 2009 at 02:24:17PM +0530, Manish Katiyar wrote: > On Mon, Feb 2, 2009 at 9:40 PM, Jan Kara wrote: > >> On Wed, Jan 28, 2009 at 10:47 AM, Manish Katiyar wrote: > >> > Below patch removes the following warning during compilation : > >> > > >> > CC [M] fs/ext4/super.o > >> > fs/ext4/super.c:949: warning: initialization from incompatible pointer type > >> > LD [M] fs/ext4/ext4.o > >> > >> Sorry, > >> > >> Tha correct patch is here. > >> > >> Signed-off-by: Manish Katiyar > > Looks fine to me. > > Acked-by: Jan Kara > > Hi Jan, > > A simple doubt. Patches acked by you will be automatically picked up > or will I have to resend it with your ack added ?? Actually, in this case Jan should pick up the patch and merge it with Mingming's ext4 quota patch which is being carried in his tree. The current ext4 code doesn't have ext4_get_reserved_space() at all. - Ted