From: Theodore Tso Subject: Re: 2.6.29-git: cannot mount ext4/loop Date: Thu, 2 Apr 2009 10:54:36 -0400 Message-ID: <20090402145436.GF10642@mit.edu> References: <20090401225351.GA22621@orion> <20090402055356.GC10642@mit.edu> <49D4BDF2.2070102@ph.tum.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Alexander Beregalov , Jens Axboe , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org To: Thiemo Nagel Return-path: Received: from THUNK.ORG ([69.25.196.29]:53186 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753377AbZDBOyp (ORCPT ); Thu, 2 Apr 2009 10:54:45 -0400 Content-Disposition: inline In-Reply-To: <49D4BDF2.2070102@ph.tum.de> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Thu, Apr 02, 2009 at 03:30:26PM +0200, Thiemo Nagel wrote: > When I added the block range checks, initially I was assuming that > when EXTENTS_FL is not set, the inode->i_data *always* contains > references to further blocks. Ted showed me wrong and added the condition > > ISREG() || ISDIR() || ( ISLNK() && !is_fast_symlink() ) > > before that assumption can be made. But maybe we need some further > restraints? It's a endian-problem; we're missing le32_to_cpu() in that patch. Sparc is big-endian. Alexander, thanks for pointing this out. We'll have to get this fixed and pushed to Linus ASAP. - Ted