From: "Indan Zupancic" Subject: Re: [GIT PULL] Ext3 latency fixes Date: Tue, 7 Apr 2009 17:39:30 +0200 (CEST) Message-ID: References: <1238742067-30814-1-git-send-email-tytso@mit.edu> <20090404135719.GA9812@mit Mime-Version: 1.0 Content-Type: text/plain;charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: "Jens Axboe" , "Theodore Tso" , "Linux Kernel Developers List" , "Ext4 Developers List" To: "Linus Torvalds" Return-path: Received: from mailer1.greenhost.nl ([195.190.28.77]:40580 "EHLO mailer1.greenhost.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758855AbZDGQCS (ORCPT ); Tue, 7 Apr 2009 12:02:18 -0400 In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Sat, April 4, 2009 17:57, Linus Torvalds wrote: > > On Sat, 4 Apr 2009, Jens Axboe wrote: >> >> Big nack on this patch. Ted, this is EXACTLY where I told you we saw big >> write regressions (sqlite performance drops by a factor of 4-5). Do a >> git log on fs/buffer.c and see the original patch (which does what your >> patch does) and the later revert. No idea why you are now suggestion >> making that exact change?! > > Jens, if I can re-create the 'fsync' times (I haven't yet), then the > default scheduler _will_ be switched to AS. http://bugzilla.kernel.org/show_bug.cgi?id=5900 I can try it with a different fs, kernel or machine as well. To me it seems this stuff is way more tricky than it should be, with all the interaction between fs, vm, io schedulers and hardware. Perhaps there's a need for one sophisticated io scheduler that gets enough information from the rest to make the right decisions. Sync or not sync isn't enough info.