From: Jan Kara Subject: Re: [PATCH] ext2: fix missing mutex_unlock in error path Date: Tue, 14 Apr 2009 09:43:57 +0200 Message-ID: <20090414074356.GC398@duck.suse.cz> References: <20090414073631.GA4145@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org To: Akinobu Mita Return-path: Received: from cantor2.suse.de ([195.135.220.15]:45261 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751984AbZDNHn6 (ORCPT ); Tue, 14 Apr 2009 03:43:58 -0400 Content-Disposition: inline In-Reply-To: <20090414073631.GA4145@localhost.localdomain> Sender: linux-ext4-owner@vger.kernel.org List-ID: Hello, On Tue 14-04-09 16:36:31, Akinobu Mita wrote: > Add missing mutex_unlock in error path in ext2_quota_write() > > Cc: Jan Kara > Signed-off-by: Akinobu Mita > --- > diff --git a/fs/ext2/super.c b/fs/ext2/super.c > index f983225..5c4afe6 100644 > --- a/fs/ext2/super.c > +++ b/fs/ext2/super.c > @@ -1395,8 +1395,10 @@ static ssize_t ext2_quota_write(struct super_block *sb, int type, > blk++; > } > out: > - if (len == towrite) > + if (len == towrite) { > + mutex_unlock(&inode->i_mutex); > return err; > + } > if (inode->i_size < off+len-towrite) > i_size_write(inode, off+len-towrite); > inode->i_version++; Thanks for the patch but I already have this patch in my quota tree from Dan Carpenter... Honza -- Jan Kara SUSE Labs, CR