From: Eric Sandeen Subject: Re: [PATCH 1/2][64-BIT] blk_t -> blk64_t in read_bitmaps(). Date: Sat, 18 Apr 2009 08:29:16 -0500 Message-ID: <49E9D5AC.80703@redhat.com> References: <30393.1240034704@gamaville.dokosmarshall.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: linux-ext4@vger.kernel.org, "Theodore Ts'o" , Valerie Aurora To: nicholas.dokos@hp.com Return-path: Received: from mx2.redhat.com ([66.187.237.31]:52874 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753732AbZDRN3W (ORCPT ); Sat, 18 Apr 2009 09:29:22 -0400 In-Reply-To: <30393.1240034704@gamaville.dokosmarshall.org> Sender: linux-ext4-owner@vger.kernel.org List-ID: Nick Dokos wrote: > e2fsck -n -f on a brand-new, never-mounted 32TiB filesystem was > detecting a lot of "Block bitmap differences". This change makes them > go away (there are are still more problems however: the run finds used > blocks in one BLOCK_UNINIT group and a free block mismatch.) > > Signed-off-by: Nick Dokos Looks right to me as well. Reviewed-by: Eric Sandeen > --- > lib/ext2fs/rw_bitmaps.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib/ext2fs/rw_bitmaps.c b/lib/ext2fs/rw_bitmaps.c > index cee6142..5b504bf 100644 > --- a/lib/ext2fs/rw_bitmaps.c > +++ b/lib/ext2fs/rw_bitmaps.c > @@ -144,9 +144,9 @@ static errcode_t read_bitmaps(ext2_filsys fs, int do_inode, int do_block) > int csum_flag = 0; > int do_image = fs->flags & EXT2_FLAG_IMAGE_FILE; > unsigned int cnt; > - blk_t blk; > - blk_t blk_itr = fs->super->s_first_data_block; > - blk_t blk_cnt; > + blk64_t blk; > + blk64_t blk_itr = fs->super->s_first_data_block; > + blk64_t blk_cnt; > ext2_ino_t ino_itr = 1; > ext2_ino_t ino_cnt; >