From: Theodore Ts'o Subject: [PATCH 2/5] ext4: Remove outdated comment about lock_super() Date: Sat, 25 Apr 2009 23:49:22 -0400 Message-ID: <1240717765-16572-3-git-send-email-tytso@mit.edu> References: <1240717765-16572-1-git-send-email-tytso@mit.edu> <1240717765-16572-2-git-send-email-tytso@mit.edu> Cc: Linux Kernel Developers List , Christoph Hellwig , Al Viro , Theodore Ts'o To: Ext4 Developers List Return-path: Received: from THUNK.ORG ([69.25.196.29]:60017 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754988AbZDZDtc (ORCPT ); Sat, 25 Apr 2009 23:49:32 -0400 In-Reply-To: <1240717765-16572-2-git-send-email-tytso@mit.edu> Sender: linux-ext4-owner@vger.kernel.org List-ID: ext4_fill_super() is no longer called by read_super(), and it is no longer called with the superblock locked. The unlock_super()/lock_super() is no longer present, so this comment is entirely superfluous. Signed-off-by: "Theodore Ts'o" --- fs/ext4/super.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index e20ff9c..e0b0c9f 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -2806,14 +2806,6 @@ no_journal: goto failed_mount4; }; - /* - * akpm: core read_super() calls in here with the superblock locked. - * That deadlocks, because orphan cleanup needs to lock the superblock - * in numerous places. Here we just pop the lock - it's relatively - * harmless, because we are now ready to accept write_super() requests, - * and aviro says that's the only reason for hanging onto the - * superblock lock. - */ EXT4_SB(sb)->s_mount_state |= EXT4_ORPHAN_FS; ext4_orphan_cleanup(sb, es); EXT4_SB(sb)->s_mount_state &= ~EXT4_ORPHAN_FS; -- 1.5.6.3