From: Theodore Tso Subject: Re: [PATCH -V4 2/2] ext4: Use -1 as the fake block number for delayed new buffer_head Date: Wed, 29 Apr 2009 11:35:21 -0400 Message-ID: <20090429153521.GC14264@mit.edu> References: <1240980441-8105-1-git-send-email-aneesh.kumar@linux.vnet.ibm.com> <1240980441-8105-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: cmm@us.ibm.com, sandeen@redhat.com, linux-ext4@vger.kernel.org To: "Aneesh Kumar K.V" Return-path: Received: from THUNK.ORG ([69.25.196.29]:59904 "EHLO thunker.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750918AbZD2Pfb (ORCPT ); Wed, 29 Apr 2009 11:35:31 -0400 Content-Disposition: inline In-Reply-To: <1240980441-8105-2-git-send-email-aneesh.kumar@linux.vnet.ibm.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Wed, Apr 29, 2009 at 10:17:21AM +0530, Aneesh Kumar K.V wrote: > Block number '0' should not be used as the fake block number for > the delayed new buffer. This will result in vfs calling umap_underlying_metadata for > block number '0'. So use -1 instead. sector_t is an unsigned type, so we probably want to use ~0 instead of -1. I can fix this up before we apply into the patch queue. Are we agreed both of these should probably be pushed to Linus for 2.6.30? - Ted