From: Nick Piggin Subject: Re: upcoming kerneloops.org item: get_page_from_freelist Date: Fri, 26 Jun 2009 10:56:29 +0200 Message-ID: <20090626085629.GC12201@wotan.suse.de> References: <20090625193806.GA6472@mit.edu> <20090625194423.GB6472@mit.edu> <20090625203743.GD6472@mit.edu> <20090625212628.GO3385@webber.adilger.int> <20090625220504.GG6472@mit.edu> <4A43F60D.2040801@redhat.com> <20090626011155.GI6472@mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Theodore Tso , Eric Sandeen , Andreas Dilger , David Rientjes , Andrew Morton , Linus Torvalds , arjan@infradead.org, linux-kernel@vger.kernel.org, cl@linux-foundation.org, linux-ext4@vger.kernel.org To: Pekka J Enberg Return-path: Received: from cantor.suse.de ([195.135.220.2]:52169 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753243AbZFZI41 (ORCPT ); Fri, 26 Jun 2009 04:56:27 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Fri, Jun 26, 2009 at 08:16:18AM +0300, Pekka Enberg wrote: > Hi Ted, > > On Thu, Jun 25, 2009 at 05:11:25PM -0500, Eric Sandeen wrote: > > > ecryptfs used to do kmalloc(PAGE_CACHE_SIZE) & virt_to_page on that, and > > > with SLUB + slub debug, that gave back non-aligned memory, causing > > > eventual corruption ... > > On Thu, 25 Jun 2009, Theodore Tso wrote: > > Grumble. Any chance we could add an kmem_cache option which requires > > the memory to be aligned? Otherwise we could rewrite our own sub-page > > allocator in ext4 that only handled aligned filesystem block sizes > > (i.e., 1k, 2k, 4k, etc.) but that would be really silly and be extra > > code that really should be done once at core functionality. > > We alredy have SLAB_HW_ALIGN but I wonder if this is a plain old bug in > SLUB. Christoph, Nick, don't we need something like this in the allocator? > Eric, does this fix your case? Well I don't understand Ted's complaint. kmem_cache_create takes an alignment argument.