From: Nick Piggin Subject: Re: upcoming kerneloops.org item: get_page_from_freelist Date: Tue, 30 Jun 2009 09:59:12 +0200 Message-ID: <20090630075912.GB11980@wotan.suse.de> References: <20090625203743.GD6472@mit.edu> <20090625212628.GO3385@webber.adilger.int> <20090625220504.GG6472@mit.edu> <4A43F60D.2040801@redhat.com> <20090626011155.GI6472@mit.edu> <20090626085629.GC12201@wotan.suse.de> <1246006681.27533.22.camel@penberg-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Pekka Enberg , Theodore Tso , Eric Sandeen , Andreas Dilger , David Rientjes , Andrew Morton , Linus Torvalds , arjan@infradead.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org To: Christoph Lameter Return-path: Received: from cantor.suse.de ([195.135.220.2]:50712 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750746AbZF3H7K (ORCPT ); Tue, 30 Jun 2009 03:59:10 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-ext4-owner@vger.kernel.org List-ID: On Mon, Jun 29, 2009 at 05:06:37PM -0400, Christoph Lameter wrote: > On Fri, 26 Jun 2009, Pekka Enberg wrote: > > > Yes, but AFAICT, SLUB_DEBUG doesn't respect the given alignment without > > my patch. > > The size parameter to calculate_alignment has no relevance unless the size > is smaller than half of the alignment. Then for some reason we do not > properly align the stuff. I never liked that.... It is properly aligned, if it was not, then it would be a bug. It should always align to *at least* the requested alignment. SLAB_HWCACHE_ALIGN is defined to align the object such that it occupies the minimal number of cache lines. This is not subjective thing to like or dislike, but just fact because that is how it was implemented from the start and that is what callers expect. If you want to minimise false sharing, then normal way would be to request internode cacheline alignment, right? This is very widely used.