From: Eric Sandeen <sandeen@redhat.com>
Subject: Re: [PATCH] e2fsprogs: fix trivial build warnings
Date: Sat, 18 Jul 2009 13:11:46 -0500
Message-ID: <4A621062.70301@redhat.com>
References: <4A5D2BED.30009@redhat.com> <20090718180413.GA2416@mit.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: ext4 development <linux-ext4@vger.kernel.org>
To: Theodore Tso <tytso@mit.edu>
In-Reply-To: <20090718180413.GA2416@mit.edu>
Sender: linux-ext4-owner@vger.kernel.org

Theodore Tso wrote:
> On Tue, Jul 14, 2009 at 08:07:57PM -0500, Eric Sandeen wrote:
>> Quite a lot of warnings have crept into the build; this fixes
>> many of the trivial ones.  Mostly unused variables, a
>> couple of header file inclusions, and one missing return
>> value.
>>
>> There are a few other warnings that I'll send patches for
>> in a bit.
> 
> Most of these ones I had fixed in the e2fsprogs maint branch already,
> except for this one:
> 
> diff --git a/misc/mke2fs.c b/misc/mke2fs.c
> index a9b01cb..e10fd35 100644
> --- a/misc/mke2fs.c
> +++ b/misc/mke2fs.c
> @@ -20,6 +20,7 @@
>  
>  #include <stdio.h>
>  #include <string.h>
> +#include <strings.h>
>  #include <fcntl.h>
>  #include <ctype.h>
>  #include <time.h>
> 
> ... which was in one of Val's patches as well, but for the life of me
> I can't figure out what warnings it's supposed to suppress.  It
> doesn't make a difference for me, and we're not using any of the
> traditional functions which would be defined in strings.h as opposed
> to string.h (i.e., bcopy, et. al.)
> 
> I assume this must be a Fedora header file thing?  What difference
> does it make for you?
> 
> 					- Ted

I think it was this:

mke2fs.c: In function 'set_os':
mke2fs.c:667: warning: implicit declaration of function 'strcasecmp'

-Eric