From: Al Viro Subject: Re: [PATCH 5/7] ext4: Convert filesystem to the new truncate calling convention Date: Tue, 22 Sep 2009 18:23:47 +0100 Message-ID: <20090922172347.GG14381@ZenIV.linux.org.uk> References: <1253200907-31392-1-git-send-email-jack@suse.cz> <1253200907-31392-6-git-send-email-jack@suse.cz> <20090922143604.GA2183@ZenIV.linux.org.uk> <20090922171604.GA31447@duck.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, LKML , linux-ext4@vger.kernel.org, linux-mm@kvack.org, npiggin@suse.de, tytso@mit.edu To: Jan Kara Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:60981 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbZIVRXo (ORCPT ); Tue, 22 Sep 2009 13:23:44 -0400 Content-Disposition: inline In-Reply-To: <20090922171604.GA31447@duck.suse.cz> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Tue, Sep 22, 2009 at 07:16:04PM +0200, Jan Kara wrote: > > No. We already have one half-finished series here; mixing it with another > > one is not going to happen. Such flags are tolerable only as bisectability > > helpers. They *must* disappear by the end of series. Before it can be > > submitted for merge. > > > > In effect, you are mixing truncate switchover with your writepage one. > > Please, split and reorder. > Well, this wasn't meant as a final version of those patches. It was > meant as a request for comment whether it makes sence to fix the problem > how I propose to fix it. If we agree on that, I'll go and convert the rest > of filesystems so that we can remove .new_writepage hack. By that time I > hope that new truncate sequence patches will be merged so that dependency > should go away as well... Could you carve just the ext4 part of truncate series out of that and post it separately?