From: "Aneesh Kumar K.V" Subject: Re: [Bug 14354] Re: ext4 increased intolerance to unclean shutdown? Date: Tue, 27 Oct 2009 15:45:34 +0530 Message-ID: <20091027101534.GA27584@skywalker.linux.vnet.ibm.com> References: <20091016091558.GA10184@mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: Theodore Tso , Parag Warudkar , LKML , linux-ext4@vger.kernel.org, bugzilla-daemon@bugzilla.kernel.org Return-path: Received: from e28smtp03.in.ibm.com ([59.145.155.3]:53502 "EHLO e28smtp03.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752810AbZJ0KAb (ORCPT ); Tue, 27 Oct 2009 06:00:31 -0400 Content-Disposition: inline In-Reply-To: <20091016091558.GA10184@mit.edu> Sender: linux-ext4-owner@vger.kernel.org List-ID: Can you try this patch ? commit a8836b1d6f92273e001012c7705ae8f4c3d5fb65 Author: Aneesh Kumar K.V Date: Tue Oct 27 15:36:38 2009 +0530 ext4: discard preallocation during truncate We need to make sure when we drop and reacquire the inode's i_data_sem we discard the inode preallocation. Otherwise we could have blocks marked as free in bitmap but still belonging to prealloc space. Signed-off-by: Aneesh Kumar K.V diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 5c5bc5d..a1ef1c3 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -209,6 +209,12 @@ static int try_to_extend_transaction(handle_t *handle, struct inode *inode) up_write(&EXT4_I(inode)->i_data_sem); ret = ext4_journal_restart(handle, blocks_for_truncate(inode)); down_write(&EXT4_I(inode)->i_data_sem); + /* + * We have dropped i_data_sem. So somebody else could have done + * block allocation. So discard the prealloc space created as a + * part of block allocation + */ + ext4_discard_preallocations(inode); return ret; }