From: Frank Mayhar Subject: Re: [PATCH] replaced BUG() with return -EIO from ext4_ext_get_blocks Date: Fri, 11 Dec 2009 12:22:03 -0800 Message-ID: <1260562923.21896.11.camel@bobble.smo.corp.google.com> References: <1260540418-11844-1-git-send-email-surbhi.palande@canonical.com> <1260554859.21896.8.camel@bobble.smo.corp.google.com> <4B22A572.5010201@redhat.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: Surbhi Palande , linux-ext4@vger.kernel.org To: Eric Sandeen Return-path: Received: from smtp-out.google.com ([216.239.33.17]:42864 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751315AbZLKUWU (ORCPT ); Fri, 11 Dec 2009 15:22:20 -0500 In-Reply-To: <4B22A572.5010201@redhat.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: On Fri, 2009-12-11 at 14:02 -0600, Eric Sandeen wrote: > My first thought was that this was a bandaid too, but I guess it can > come about due to on-disk corruption for any reason, so it should > be handled gracefully, and I suppose this approach seems fine. That's why we've been running with it, yes. > Since this is catching on-disk corruption, though, it'd be better to call > ext4_error() and let the mount-time error-handling policy decide what to do. > > I like having more info but below seems awfully wordy ;) Maybe the first > printk would suffice, and switching it to an ext4_error() would be best, > I think. Okay, I'll rework the patch a bit and resubmit it. -- Frank Mayhar Google, Inc.