From: Surbhi Palande Subject: Re: [PATCH] replaced BUG() with return -EIO from ext4_ext_get_blocks Date: Sat, 12 Dec 2009 00:11:31 +0200 Message-ID: <4B22C393.2090709@canonical.com> References: <1260540418-11844-1-git-send-email-surbhi.palande@canonical.com> <1260554859.21896.8.camel@bobble.smo.corp.google.com> <4B22A572.5010201@redhat.com> <1260562923.21896.11.camel@bobble.smo.corp.google.com> Reply-To: surbhi.palande@canonical.com Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Eric Sandeen , linux-ext4@vger.kernel.org To: Frank Mayhar Return-path: Received: from adelie.canonical.com ([91.189.90.139]:56081 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761152AbZLKWLa (ORCPT ); Fri, 11 Dec 2009 17:11:30 -0500 In-Reply-To: <1260562923.21896.11.camel@bobble.smo.corp.google.com> Sender: linux-ext4-owner@vger.kernel.org List-ID: Hi Frank, Frank Mayhar wrote: > On Fri, 2009-12-11 at 14:02 -0600, Eric Sandeen wrote: > >> My first thought was that this was a bandaid too, but I guess it can >> come about due to on-disk corruption for any reason, so it should >> be handled gracefully, and I suppose this approach seems fine. >> > > That's why we've been running with it, yes. > > >> Since this is catching on-disk corruption, though, it'd be better to call >> ext4_error() and let the mount-time error-handling policy decide what to do. >> >> I like having more info but below seems awfully wordy ;) Maybe the first >> printk would suffice, and switching it to an ext4_error() would be best, >> I think. >> > > Okay, I'll rework the patch a bit and resubmit it. > Since I published this patch first against a reported upstream bug, I will work on the comments and resubmit the patch! Thanks for your comments ! Warm Regards, Surbhi.