From: "Aneesh Kumar K. V" <aneesh.kumar@linux.vnet.ibm.com>
Subject: Re: [Bug 15018] ext4 backtraces out of nowhere
Date: Wed, 27 Jan 2010 15:16:30 +0530
Message-ID: <87636nj2x5.fsf@linux.vnet.ibm.com>
References: <bug-15018-13602@http.bugzilla.kernel.org/>
	<201001262319.o0QNJNp0024737@demeter.kernel.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
To: bugzilla-daemon@bugzilla.kernel.org, linux-ext4@vger.kernel.org
In-Reply-To: <201001262319.o0QNJNp0024737@demeter.kernel.org>
Sender: linux-ext4-owner@vger.kernel.org

On Tue, 26 Jan 2010 23:19:23 GMT, bugzilla-daemon@bugzilla.kernel.org wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=15018
> 
> 
> 
> 
> 
> --- Comment #4 from Jan Kara <jack@suse.cz>  2010-01-26 23:19:18 ---
> Hmm, I don't like the code in ext4_da_reserve_space even after your patch - the
> retries are duplicated with the ones from ext4_da_write_begin and calling
> write_inode_now from ext4_da_write_begin doesn't make too much sense either -
> why not write all inodes with delayed allocation if we want to write something?
> 
> Actually, instead of retrying delayed allocation, I think it makes more sense
> to just fall back to normal allocation. Attached patch does that and it also
> allows me to completely fill user's quota.
> 

Switching to non delayed allocation may not guarantee that we succeed in block
allocation. For quota we really need to flush this inode. Even if we
flush other inodes of other user we may still get a quota error

-aneesh